Change ConstantArray::Metadata to Scalar#6474
Closed
connortsui20 wants to merge 2 commits intoct/deserialize-with-buffersfrom
Closed
Change ConstantArray::Metadata to Scalar#6474connortsui20 wants to merge 2 commits intoct/deserialize-with-buffersfrom
ConstantArray::Metadata to Scalar#6474connortsui20 wants to merge 2 commits intoct/deserialize-with-buffersfrom
Conversation
Adds buffers as a parameter to `VTable::deserialize`. This is needed because we now _sometimes_ store the `ConstantArray` scalar in the metadata and _sometimes_ in the buffers. We want to make the metadata for `ConstantArray` a `Scalar` instead of `Option<Scalar>`, and that will come in a followup PR. Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
connortsui20
changed the base branch from
develop
to
ct/deserialize-with-buffers
connortsui20
force-pushed
the
ct/deserialize-with-buffers
branch
2 times, most recently
from
468f06d to
bc8066f
Compare
Contributor
Author
|
Closing for now while we figure out if we want to have two discrete kinds of |
connortsui20
added a commit
that referenced
this pull request
Feb 13, 2026
Adds buffers as a parameter to `VTable::deserialize`. This is needed because we now _sometimes_ store the `ConstantArray` scalar in the metadata and _sometimes_ in the buffers. We want to make the metadata for `ConstantArray` a `Scalar` instead of `Option<Scalar>`, and that will come in a followup PR. Followup PR: #6474 This is also blocking the extension scalar work we want to do. Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on top of #6473
This is also blocking the extension scalar work we want to do.