Skip to content

Pass buffers to VTable::deserialize#6473

Merged
connortsui20 merged 2 commits intodevelopfrom
ct/deserialize-with-buffers
Feb 13, 2026
Merged

Pass buffers to VTable::deserialize#6473
connortsui20 merged 2 commits intodevelopfrom
ct/deserialize-with-buffers

Conversation

@connortsui20
Copy link
Contributor

@connortsui20 connortsui20 commented Feb 12, 2026

Adds buffers as a parameter to VTable::deserialize. This is needed because we now sometimes store the ConstantArray scalar in the metadata and sometimes in the buffers. We want to make the metadata for ConstantArray a Scalar instead of Option<Scalar>, and that will come in a followup PR.

Followup PR: #6474

This is also blocking the extension scalar work we want to do.

@connortsui20 connortsui20 added the changelog/break A breaking API change label Feb 12, 2026
@codspeed-hq
Copy link

codspeed-hq bot commented Feb 12, 2026

Merging this PR will not alter performance

✅ 1135 untouched benchmarks
⏩ 1268 skipped benchmarks1


Comparing ct/deserialize-with-buffers (bc8066f) with develop (be86749)

Open in CodSpeed

Footnotes

  1. 1268 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@connortsui20 connortsui20 enabled auto-merge (squash) February 13, 2026 15:43
@connortsui20 connortsui20 force-pushed the ct/deserialize-with-buffers branch from 868654c to 468f06d Compare February 13, 2026 15:44
Adds buffers as a parameter to `VTable::deserialize`. This is needed
because we now _sometimes_ store the `ConstantArray` scalar in the
metadata and _sometimes_ in the buffers. We want to make the metadata
for `ConstantArray` a `Scalar` instead of `Option<Scalar>`, and that
will come in a followup PR.

Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
@connortsui20 connortsui20 force-pushed the ct/deserialize-with-buffers branch from 468f06d to bc8066f Compare February 13, 2026 16:03
@connortsui20 connortsui20 merged commit 19f8785 into develop Feb 13, 2026
47 checks passed
@connortsui20 connortsui20 deleted the ct/deserialize-with-buffers branch February 13, 2026 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/break A breaking API change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants