Skip to content

rimage: manifest: Make "cold" section size 0 when not used #10612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dbaluta wants to merge 1 commit into
base: main
Choose a base branch
from
Open

rimage: manifest: Make "cold" section size 0 when not used #10612

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions tools/rimage/src/include/rimage/sof/user/manifest.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,6 +257,10 @@ struct sof_man_module_manifest {
* enough and that SRAM will not use these addresses.
*/
#define SOF_MODULE_DRAM_LINK_START 0
#if CONFIG_COLD_STORE_EXECUTE_DRAM
#define SOF_MODULE_DRAM_LINK_END 0x08000000
#else
#define SOF_MODULE_DRAM_LINK_END SOF_MODULE_DRAM_LINK_START
#endif
Comment on lines +260 to +264
Copy link

Copilot AI Mar 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment block above SOF_MODULE_DRAM_LINK_START (lines 253–258) only accurately describes the behavior when CONFIG_COLD_STORE_EXECUTE_DRAM is enabled. After this change, when the config is not enabled, SOF_MODULE_DRAM_LINK_END equals SOF_MODULE_DRAM_LINK_START (i.e., 0), making the DRAM link range empty and disabling detached-section treatment entirely. The comment should be updated to reflect this conditional behavior — for example, noting that when CONFIG_COLD_STORE_EXECUTE_DRAM is not set, the range is empty and no sections are treated as detached.

Copilot uses AI. Check for mistakes.

#endif /* __RIMAGE_USER_MANIFEST_H__ */
Loading