rimage: manifest: Make "cold" section size 0 when not used#10612
rimage: manifest: Make "cold" section size 0 when not used#10612dbaluta wants to merge 1 commit intothesofproject:mainfrom
Conversation
dbaluta
requested review from
kv2019i,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
There are some non-critical data and code sections that are kept in DRAM to be accessed and executed from there without being copied to SRAM. Such sections are marked as `detached` and linked into a separate "cold.mod" module. rimage considers zones starting at SOF_MODULE_DRAM_LINK_START to SOF_MODULE_DRAM_LINK_END to be cold and links them separately. On i.MX8MP for M7 support this overalps with ITCM/DTCM/OCRAM areas which causes boot problems. So, treat all sections as SRAM when CONFIG_COLD_STORE_EXECUTE_DRAM is not enabled by making DRAM link sections size equal to 0 in this case. Closes: thesofproject#10602 Signed-off-by: Daniel Baluta <daniel.baluta@nxp.com>
There was a problem hiding this comment.
Pull request overview
This PR fixes a boot problem on i.MX8MP (M7) where ITCM/DTCM/OCRAM memory sections were incorrectly treated as "detached" (cold/DRAM) by rimage, causing them to be omitted from the output image. The fix makes SOF_MODULE_DRAM_LINK_END equal to SOF_MODULE_DRAM_LINK_START (both 0) when CONFIG_COLD_STORE_EXECUTE_DRAM is not enabled, effectively collapsing the DRAM link range to empty and ensuring all sections are treated as SRAM.
Changes:
- When
CONFIG_COLD_STORE_EXECUTE_DRAMis disabled,SOF_MODULE_DRAM_LINK_ENDis defined asSOF_MODULE_DRAM_LINK_START(0), making the DRAM detection range empty. - When
CONFIG_COLD_STORE_EXECUTE_DRAMis enabled, behavior is unchanged (SOF_MODULE_DRAM_LINK_END= 0x08000000).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| #if CONFIG_COLD_STORE_EXECUTE_DRAM | ||
| #define SOF_MODULE_DRAM_LINK_END 0x08000000 | ||
| #else | ||
| #define SOF_MODULE_DRAM_LINK_END SOF_MODULE_DRAM_LINK_START | ||
| #endif |
There was a problem hiding this comment.
The comment block above SOF_MODULE_DRAM_LINK_START (lines 253–258) only accurately describes the behavior when CONFIG_COLD_STORE_EXECUTE_DRAM is enabled. After this change, when the config is not enabled, SOF_MODULE_DRAM_LINK_END equals SOF_MODULE_DRAM_LINK_START (i.e., 0), making the DRAM link range empty and disabling detached-section treatment entirely. The comment should be updated to reflect this conditional behavior — for example, noting that when CONFIG_COLD_STORE_EXECUTE_DRAM is not set, the range is empty and no sections are treated as detached.
There are some non-critical data and code sections that are kept in DRAM to be accessed and executed from there without being copyind to SRAM.
Such sections are marked as
detachedand linked into a separate "cold.mod" module.rimage considers zones starting at SOF_MODULE_DRAM_LINK_START to SOF_MODULE_DRAM_LINK_END to be cold and links them separately.
On i.MX8MP for M7 support this overalps with ITCM/DTCM/OCRAM areas which causes boot problems.
So, treat all sections as SRAM when CONFIG_COLD_STORE_EXECUTE_DRAM is not enabled by making DRAM link sections size equal to 0 in this case.
Closes: #10602