Skip to content

Fix flaky Puma plugin tests caused by port collision #733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
diogovernier wants to merge 1 commit into
base: main
Choose a base branch
from
+11 −1
Open

Fix flaky Puma plugin tests caused by port collision #733

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion test/integration/puma/plugin_testing.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
# frozen_string_literal: true

require "test_helper"
require "socket"

module PluginTesting
extend ActiveSupport::Concern
Expand All @@ -12,10 +13,12 @@ module PluginTesting
setup do
FileUtils.mkdir_p Rails.root.join("tmp", "pids")

@port = find_available_port

Dir.chdir("test/dummy") do
cmd = %W[
bundle exec puma
-b tcp://127.0.0.1:9222
-b tcp://127.0.0.1:#{@port}
-C config/puma_#{solid_queue_mode}.rb
-s
config.ru
Expand Down Expand Up @@ -57,4 +60,11 @@ module PluginTesting
def solid_queue_mode
raise NotImplementedError
end

def find_available_port
server = TCPServer.new("127.0.0.1", 0)
server.addr[1]
ensure
server&.close
end
end
Loading