Fix flaky Puma plugin tests caused by port collision#733
Open
diogovernier wants to merge 1 commit intorails:mainfrom
Open
Fix flaky Puma plugin tests caused by port collision#733diogovernier wants to merge 1 commit intorails:mainfrom
diogovernier wants to merge 1 commit intorails:mainfrom
Conversation
The Puma plugin tests bind to a hardcoded port (9222). When a test teardown completes and the next test setup starts, the OS may still hold the port in TCP TIME_WAIT state, causing EADDRINUSE failures that cascade into nil process lookups and false test failures. Replace the hardcoded port with a dynamically allocated one via TCPServer, so each test gets a guaranteed available port.
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related to #602.
Puma plugin tests bind to a hardcoded port (9222). When consecutive tests run, the OS may still hold the previous port in TCP TIME_WAIT state, causing
EADDRINUSEthat cascades into false test failures.This replaces the fixed port with dynamic allocation via
TCPServer, so each test gets a guaranteed available port.To be precise, this PR should fix this flaky test, for instance: https://github.com/rails/solid_queue/actions/runs/24190892956/job/70607570480?pr=732
What changed
test/integration/puma/plugin_testing.rbTCPServer.new("127.0.0.1", 0)dynamic allocation