Skip to content

fix(typegen): fields dialog overflow in bottom settings bar #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eluce2 merged 1 commit into from
Mar 16, 2026
+8 −4
Merged

fix(typegen): fields dialog overflow in bottom settings bar #146

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fix-typegen-fields-dialog-overflow.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@proofkit/typegen": patch
---

Fix overflow in metadata fields dialog where bottom settings form overlapped with data grid
5 changes: 2 additions & 3 deletions packages/typegen/web/src/components/metadata-fields-dialog/FieldsDataGrid.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,14 +73,13 @@ export function FieldsDataGrid({ table, isLoading, isError, error, open }: Field
table={table}
tableLayout={{ width: "auto", headerSticky: true }}
>
<DataGridContainer border={true}>
<DataGridContainer border={true} className="h-full">
<div
className="overflow-auto"
ref={tableContainerRef}
style={{
contain: "strict",
height: "650px",
maxHeight: "650px",
height: "100%",
}}
>
<table className="w-full border-separate border-spacing-0">
Expand Down
2 changes: 1 addition & 1 deletion packages/typegen/web/src/components/metadata-fields-dialog/MetadataFieldsDialog.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ export function MetadataFieldsDialog({ open, onOpenChange, tableName, configInde
Including {selectedFieldsCount} of {fieldsData.length} fields for {tableName || "Table"}
</DialogTitle>
</DialogHeader>
<DialogBody className="flex min-h-0 flex-1 flex-col overflow-x-auto overflow-y-auto">
<DialogBody className="flex min-h-0 flex-1 flex-col overflow-hidden">
<div className="mb-2 shrink-0 space-y-2">
<InputWrapper>
<Search className="size-4" />
Expand Down
Loading