Skip to content

fix(typegen): fields dialog overflow in bottom settings bar#146

Merged
eluce2 merged 1 commit intomainfrom
03-16-fix_typegen_fields_dialog_overflow_in_bottom_settings_bar
Mar 16, 2026
Merged

fix(typegen): fields dialog overflow in bottom settings bar#146
eluce2 merged 1 commit intomainfrom
03-16-fix_typegen_fields_dialog_overflow_in_bottom_settings_bar

Conversation

@eluce2
Copy link
Collaborator

@eluce2 eluce2 commented Mar 16, 2026

Summary by CodeRabbit

  • Bug Fixes
    • Fixed overflow issue in the metadata fields dialog where the bottom settings form overlapped with the data grid.

@vercel
Copy link

vercel bot commented Mar 16, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
proofkit-docs Ready Ready Preview Mar 16, 2026 5:08pm

Request Review

Copy link
Collaborator Author

eluce2 commented Mar 16, 2026

This stack of pull requests is managed by Graphite. Learn more about stacking.

@coderabbitai
Copy link

coderabbitai bot commented Mar 16, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 67fff078-6bc2-4740-affb-6c5ab58752c5

📥 Commits

Reviewing files that changed from the base of the PR and between 97994ac and 8ca7a1e.

📒 Files selected for processing (3)
  • .changeset/fix-typegen-fields-dialog-overflow.md
  • packages/typegen/web/src/components/metadata-fields-dialog/FieldsDataGrid.tsx
  • packages/typegen/web/src/components/metadata-fields-dialog/MetadataFieldsDialog.tsx

📝 Walkthrough

Walkthrough

This PR fixes an overflow issue in the metadata fields dialog where the bottom settings form overlapped with the data grid. The scroll container height is changed from fixed (650px) to fluid (100%), and dialog body scrolling behavior is adjusted by removing overflow styling.

Changes

Cohort / File(s) Summary
Changelog Entry
.changeset/fix-typegen-fields-dialog-overflow.md
New changelog entry documenting a patch version fix for the metadata fields dialog overflow issue.
Metadata Fields Dialog Components
packages/typegen/web/src/components/metadata-fields-dialog/FieldsDataGrid.tsx, packages/typegen/web/src/components/metadata-fields-dialog/MetadataFieldsDialog.tsx
Styling adjustments: scroll container height changed from fixed 650px to fluid 100%, and dialog body overflow behavior changed from overflow-x-auto overflow-y-auto to overflow-hidden to prevent overlapping content.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main fix: addressing an overflow issue in the fields dialog's bottom settings bar, which aligns with the changeset's purpose of fixing dialog overflow.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch 03-16-fix_typegen_fields_dialog_overflow_in_bottom_settings_bar
📝 Coding Plan
  • Generate coding plan for human review comments

Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Mar 16, 2026

Open in StackBlitz

@proofkit/better-auth

pnpm add https://pkg.pr.new/proofgeist/proofkit/@proofkit/better-auth@146

@proofkit/cli

pnpm add https://pkg.pr.new/proofgeist/proofkit/@proofkit/cli@146

create-proofkit

pnpm add https://pkg.pr.new/proofgeist/proofkit/create-proofkit@146

@proofkit/fmdapi

pnpm add https://pkg.pr.new/proofgeist/proofkit/@proofkit/fmdapi@146

@proofkit/fmodata

pnpm add https://pkg.pr.new/proofgeist/proofkit/@proofkit/fmodata@146

@proofkit/typegen

pnpm add https://pkg.pr.new/proofgeist/proofkit/@proofkit/typegen@146

@proofkit/webviewer

pnpm add https://pkg.pr.new/proofgeist/proofkit/@proofkit/webviewer@146

commit: 8ca7a1e

@eluce2 eluce2 merged commit 17b40aa into main Mar 16, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants