Skip to content

chore: fix npm caching in linter workflow#247

Merged
mobilemind merged 2 commits intochore/streamline-ci-cdfrom
copilot/sub-pr-246
Mar 22, 2026
Merged

chore: fix npm caching in linter workflow#247
mobilemind merged 2 commits intochore/streamline-ci-cdfrom
copilot/sub-pr-246

Conversation

Copy link
Contributor

Copilot AI commented Mar 22, 2026

npm ci deletes node_modules before installing, making the previous actions/cache step that cached node_modules a no-op — restoring it provided zero speedup.

Changes

  • Remove the standalone actions/cache@v5 step caching node_modules
  • Add cache: 'npm' to actions/setup-node@v6, which caches ~/.npm keyed by package-lock.json — the correct layer to cache for npm ci workflows
- name: "Setup Node.js"
  uses: actions/setup-node@v6
  with:
    node-version: '22.x'
    cache: 'npm'

📍 Connect Copilot coding agent with Jira, Azure Boards or Linear to delegate work to Copilot in one click without leaving your project management tool.

Copilot AI changed the title [WIP] [WIP] Chore: address feedback on CI/CD streamline from PR #246 chore: fix npm caching in linter workflow Mar 22, 2026
Copilot AI requested a review from mobilemind March 22, 2026 06:52
Copy link
Owner

@mobilemind mobilemind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@mobilemind mobilemind marked this pull request as ready for review March 22, 2026 06:57
Copilot AI review requested due to automatic review settings March 22, 2026 06:57
@mobilemind mobilemind merged commit 3da6e29 into chore/streamline-ci-cd Mar 22, 2026
1 check passed
@mobilemind mobilemind deleted the copilot/sub-pr-246 branch March 22, 2026 06:57
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the linter GitHub Actions workflow to use the built-in npm cache support in actions/setup-node instead of caching node_modules, aligning caching behavior with npm ci semantics.

Changes:

  • Removed the standalone actions/cache step that cached node_modules.
  • Enabled actions/setup-node@v6 npm caching (cache: 'npm') keyed off package-lock.json.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants