chore: streamline ci/cd (dump huge Super-Linter) by mobilemind · Pull Request #246 · mobilemind/text2datauri

mobilemind · 2026-03-22T05:54:17Z

chore: streamline ci/cd (dump huge Super-Linter)

Copilot

Pull request overview

This PR streamlines the repository’s CI/CD linting by removing Super-Linter and replacing it with direct ESLint/markdownlint/yamllint/JSON checks, alongside some config cleanup.

Changes:

Add local lint scripts and devDependencies for ESLint + markdownlint.
Replace Super-Linter workflow with explicit lint steps (ESLint, Markdown, YAML, JSON).
Move markdownlint configuration to a repo-level config file and adjust YAML lint ignore patterns.

Reviewed changes

Copilot reviewed 7 out of 9 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
package.json	Adds `lint`/`lint:md` scripts and introduces devDependencies for lint tooling.
package-lock.json	Locks the new devDependency toolchain (large lockfile expansion).
eslint.config.js	Updates ESLint “files” targets to match new config location.
SECURITY.md	Clarifies wording to “Zero Production Dependencies”.
.yamllint.yml	Removes previously ignored workflow files from yamllint ignore list.
.markdownlint.json	Adds markdownlint rule configuration at repo root.
.github/workflows/linter.yml	Replaces Super-Linter with explicit lint commands and caching changes.
.github/linters/.markdownlint.js	Removes the old markdownlint config used by Super-Linter.
.github/actionlint.yaml	Adds actionlint configuration (but workflow integration is not included).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-03-22T05:57:58Z

.github/workflows/linter.yml

+            -print0 | xargs -0 -I{} node -e \
+            "try{JSON.parse(require('fs').readFileSync('{}','utf8'))}catch(e){console.error('{}:',e.message);process.exit(1)}"


This workflow runs yamllint . with line-length max 92 (see .yamllint.yml), but the JSON lint step includes very long YAML lines (notably the inline node -e script). This is likely to trigger yamllint and fail the job. Consider refactoring the JSON lint command to avoid long lines (e.g., use a heredoc/multi-line script) or disable line-length for this workflow file.

Suggested change

-print0 | xargs -0 -I{} node -e \

"try{JSON.parse(require('fs').readFileSync('{}','utf8'))}catch(e){console.error('{}:',e.message);process.exit(1)}"

-print0 | xargs -0 -I{} jq empty "{}"

.github/workflows/linter.yml

package.json

.github/workflows/linter.yml

Copilot

Pull request overview

Copilot reviewed 7 out of 9 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

.github/workflows/linter.yml

Copilot

Pull request overview

Copilot reviewed 8 out of 10 changed files in this pull request and generated 3 comments.

Comments suppressed due to low confidence (1)

eslint.config.js:8

eslint is run as eslint ., but this flat config only applies to eslint.config.js, Gruntfile.js, tasks/*.js, and test/*.js. The CLI entrypoint under bin/ is excluded, so it won't be linted in CI. Consider adding bin/*.js (and any other shipped JS entrypoints) to the files patterns so linting covers the published code.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

README.md

.github/workflows/linter.yml

…inters

Copilot · 2026-03-22T06:50:00Z

@mobilemind I've opened a new pull request, #247, to work on those changes. Once the pull request is ready, I'll request review from you.

Co-authored-by: mobilemind <19366+mobilemind@users.noreply.github.com> Agent-Logs-Url: https://github.com/mobilemind/text2datauri/sessions/5afb4df8-2441-4f20-bdc9-d9ebc0159b18

chore: fix npm caching in linter workflow

Copilot

Pull request overview

Copilot reviewed 9 out of 11 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-03-22T07:00:55Z

.github/workflows/linter.yml

+
+      - name: "YAML lint"
+        run: pip install --quiet yamllint && yamllint .
+


Previously this workflow validated GitHub Actions workflow syntax via Super-Linter (VALIDATE_GITHUB_ACTIONS: true). After removing Super-Linter, the workflow only runs yamllint, which won’t catch GitHub Actions-specific issues. If you still want that coverage, add an actionlint step (and keep .github/actionlint.yaml), otherwise consider removing .github/actionlint.yaml since it’s currently unused.

Suggested change

- name: "GitHub Actions workflow lint"

uses: docker://ghcr.io/rhysd/actionlint:latest

with:

args: -color

Copilot · 2026-03-22T07:00:56Z

package.json

+    "@eslint/js": "~10.0.1",
+    "eslint": "~10.1.0",
+    "eslint-plugin-n": "~17.24.0",
+    "markdownlint-cli2": "~0.22.0"


The repo’s .npmrc sets save-exact=true (no ^/~ ranges) for reproducible installs, but the new devDependencies are specified with ~ ranges. Please pin these devDependencies to exact versions to match the repo convention (and update the lockfile accordingly).

Suggested change

"@eslint/js": "~10.0.1",

"eslint": "~10.1.0",

"eslint-plugin-n": "~17.24.0",

"markdownlint-cli2": "~0.22.0"

"@eslint/js": "10.0.1",

"eslint": "10.1.0",

"eslint-plugin-n": "17.24.0",

"markdownlint-cli2": "0.22.0"

chore: streamline ci/cd (dump huge Super-Linter)

b93b673

mobilemind requested a review from Copilot March 22, 2026 05:54

mobilemind self-assigned this Mar 22, 2026

mobilemind added the chore label Mar 22, 2026

Copilot started reviewing on behalf of mobilemind March 22, 2026 05:54 View session

Copilot AI reviewed Mar 22, 2026

View reviewed changes

mobilemind added 2 commits March 21, 2026 23:03

fix: don’t check push (done locally), no strict engine to lint

ba382be

docs(SECURITY.md): fix Markdown lint warning

57ffc86

Copilot AI review requested due to automatic review settings March 22, 2026 06:19

Copilot started reviewing on behalf of mobilemind March 22, 2026 06:20 View session

Copilot AI reviewed Mar 22, 2026

View reviewed changes

.github/workflows/linter.yml Outdated Show resolved Hide resolved

mobilemind added 2 commits March 21, 2026 23:30

chore(linter): leverage package-lock.json w/ npm ci AND caching

d2a379d

chore: bump version (devops changed package.json)

dd10ce7

Copilot AI review requested due to automatic review settings March 22, 2026 06:39

Copilot started reviewing on behalf of mobilemind March 22, 2026 06:40 View session

Copilot AI reviewed Mar 22, 2026

View reviewed changes

README.md Show resolved Hide resolved

.github/workflows/linter.yml Outdated Show resolved Hide resolved

.github/workflows/linter.yml Show resolved Hide resolved

mobilemind and others added 2 commits March 21, 2026 23:47

chore: update dependabot checks, add flexible semver to "no-change" l…

4ea1220

…inters

Initial plan

0c0333a

Copilot AI mentioned this pull request Mar 22, 2026

chore: fix npm caching in linter workflow #247

Merged

Copilot AI and others added 2 commits March 22, 2026 06:51

fix: use setup-node built-in npm cache instead of caching node_modules

cfb0f15

Co-authored-by: mobilemind <19366+mobilemind@users.noreply.github.com> Agent-Logs-Url: https://github.com/mobilemind/text2datauri/sessions/5afb4df8-2441-4f20-bdc9-d9ebc0159b18

Merge pull request #247 from mobilemind/copilot/sub-pr-246

3da6e29

chore: fix npm caching in linter workflow

Copilot AI review requested due to automatic review settings March 22, 2026 06:57

Copilot started reviewing on behalf of mobilemind March 22, 2026 06:58 View session

mobilemind merged commit 18586bb into main Mar 22, 2026
9 checks passed

mobilemind deleted the chore/streamline-ci-cd branch March 22, 2026 07:00

Copilot AI reviewed Mar 22, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: streamline ci/cd (dump huge Super-Linter)#246

chore: streamline ci/cd (dump huge Super-Linter)#246
mobilemind merged 9 commits intomainfrom
chore/streamline-ci-cd

mobilemind commented Mar 22, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Mar 22, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI commented Mar 22, 2026

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Mar 22, 2026

Uh oh!

Copilot AI Mar 22, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		-print0 \| xargs -0 -I{} node -e \
		"try{JSON.parse(require('fs').readFileSync('{}','utf8'))}catch(e){console.error('{}:',e.message);process.exit(1)}"

	-print0 \| xargs -0 -I{} node -e \
	"try{JSON.parse(require('fs').readFileSync('{}','utf8'))}catch(e){console.error('{}:',e.message);process.exit(1)}"
	-print0 \| xargs -0 -I{} jq empty "{}"


		- name: "YAML lint"
		run: pip install --quiet yamllint && yamllint .

+      - name: "GitHub Actions workflow lint"
+        uses: docker://ghcr.io/rhysd/actionlint:latest
+        with:
+          args: -color

Conversation

mobilemind commented Mar 22, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Mar 22, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI commented Mar 22, 2026

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Mar 22, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 22, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants