Skip to content

fix(security): replace shell=True with shell=False in subprocess calls #2111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Jah-yee wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −5
Open

fix(security): replace shell=True with shell=False in subprocess calls #2111

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ...ples/voice-assistant-nodejs/tenapp/ten_packages/extension/main_nodejs/tools/run_script.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
# See the LICENSE file for more information.
#
import argparse
import shlex
import subprocess
import sys
import os
Expand All @@ -15,7 +16,7 @@ def run_cmd(cmd: str, env: dict[str, str] | None = None) -> int:
if env is None:
env = os.environ.copy()
print(f"Running: {cmd}")
result = subprocess.run(cmd, shell=True, check=True, env=env)
result = subprocess.run(shlex.split(cmd), shell=False, check=True, env=env)
return result.returncode


Expand Down
3 changes: 2 additions & 1 deletion packages/core_apps/default_app_cpp/tools/run_script.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@

import argparse
import platform
import shlex
import subprocess
import sys

Expand Down Expand Up @@ -52,7 +53,7 @@ def detect_arch() -> str:
def run_cmd(cmd: str) -> int:
"""Run a shell command."""
print(f"Running: {cmd}")
result = subprocess.run(cmd, shell=True, check=True)
result = subprocess.run(shlex.split(cmd), shell=False, check=True)
return result.returncode


Expand Down
3 changes: 2 additions & 1 deletion packages/core_extensions/default_extension_cpp/tools/run_script.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
#
import argparse
import platform
import shlex
import subprocess
import sys
import os as os_module
Expand Down Expand Up @@ -53,7 +54,7 @@ def run_cmd(cmd: str, env: dict[str, str] | None = None) -> int:
if env is None:
env = os_module.environ.copy()
print(f"Running: {cmd}")
result = subprocess.run(cmd, shell=True, check=True, env=env)
result = subprocess.run(shlex.split(cmd), shell=False, check=True, env=env)
return result.returncode


Expand Down
3 changes: 2 additions & 1 deletion packages/core_extensions/default_extension_nodejs/tools/run_script.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
# See the LICENSE file for more information.
#
import argparse
import shlex
import subprocess
import sys
import os
Expand All @@ -15,7 +16,7 @@ def run_cmd(cmd: str, env: dict[str, str] | None = None) -> int:
if env is None:
env = os.environ.copy()
print(f"Running: {cmd}")
result = subprocess.run(cmd, shell=True, check=True, env=env)
result = subprocess.run(shlex.split(cmd), shell=False, check=True, env=env)
return result.returncode


Expand Down
3 changes: 2 additions & 1 deletion packages/example_apps/transcriber_demo/ten_packages/extension/vtt_nodejs/tools/run_script.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
# See the LICENSE file for more information.
#
import argparse
import shlex
import subprocess
import sys
import os
Expand All @@ -15,7 +16,7 @@ def run_cmd(cmd: str, env: dict[str, str] | None = None) -> int:
if env is None:
env = os.environ.copy()
print(f"Running: {cmd}")
result = subprocess.run(cmd, shell=True, check=True, env=env)
result = subprocess.run(shlex.split(cmd), shell=False, check=True, env=env)
return result.returncode


Expand Down
Loading