fix(security): replace shell=True with shell=False in subprocess calls#2111
Open
Jah-yee wants to merge 1 commit intoTEN-framework:mainfrom
Open
fix(security): replace shell=True with shell=False in subprocess calls#2111Jah-yee wants to merge 1 commit intoTEN-framework:mainfrom
Jah-yee wants to merge 1 commit intoTEN-framework:mainfrom
Conversation
This patch addresses security vulnerabilities reported in issues TEN-framework#2107 and TEN-framework#2106 by replacing shell=True with shell=False in subprocess.run() calls. Using shell=True makes command construction bugs easier to exploit by propagating current shell settings and variables. Changes: - Added shlex import to properly parse command strings - Changed subprocess.run(cmd, shell=True, ...) to subprocess.run(shlex.split(cmd), shell=False, ...) - Applied fixes to 5 files with the same vulnerability pattern Affected files: - ai_agents/agents/examples/voice-assistant-nodejs/tenapp/ten_packages/extension/main_nodejs/tools/run_script.py - packages/core_apps/default_app_cpp/tools/run_script.py - packages/core_extensions/default_extension_cpp/tools/run_script.py - packages/core_extensions/default_extension_nodejs/tools/run_script.py - packages/example_apps/transcriber_demo/ten_packages/extension/vtt_nodejs/tools/run_script.py
Jah-yee
pushed a commit
to Jah-yee/ten-framework
that referenced
this pull request
Mar 18, 2026
…njection Replaces dangerous shell=True in subprocess.run with shell=False + shlex.split() to prevent shell injection vulnerabilities in 5 files: - ai_agents/agents/examples/voice-assistant-nodejs/.../run_script.py - packages/core_apps/default_app_cpp/tools/run_script.py - packages/core_extensions/default_extension_cpp/tools/run_script.py - packages/core_extensions/default_extension_nodejs/tools/run_script.py - packages/example_apps/transcriber_demo/.../run_script.py Fixes issues TEN-framework#2107, TEN-framework#2106, TEN-framework#2111, TEN-framework#2113, TEN-framework#2114
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Good day,
This PR addresses security vulnerabilities reported in issues #2107 and #2106.
Problem
Using
shell=Trueinsubprocess.run()calls makes command construction bugs easier to exploit by propagating current shell settings and variables. This is a well-known security anti-pattern.Solution
Replaced
shell=Truewithshell=Falseand usedshlex.split()to properly parse command strings into list arguments.Changes
shleximport to properly parse command stringssubprocess.run(cmd, shell=True, ...)tosubprocess.run(shlex.split(cmd), shell=False, ...)ai_agents/agents/examples/voice-assistant-nodejs/tenapp/ten_packages/extension/main_nodejs/tools/run_script.pypackages/core_apps/default_app_cpp/tools/run_script.pypackages/core_extensions/default_extension_cpp/tools/run_script.pypackages/core_extensions/default_extension_nodejs/tools/run_script.pypackages/example_apps/transcriber_demo/ten_packages/extension/vtt_nodejs/tools/run_script.pyTesting
The code changes have been reviewed locally. The
shlex.split()function correctly handles:npm install)npm run build)Local testing with Python 3 shows the modified code works correctly with the new approach.
感谢你们的奉献，希望能提供帮助。如果我解决得有问题或有待商妥的地方，请在下面留言，我会来处理。
Warmly,
Jah-yee