feat(services): refactor auth and color configuration flow#540
Open
simsonas86 wants to merge 1 commit intoProject-Sloth:mainfrom
Open
feat(services): refactor auth and color configuration flow#540simsonas86 wants to merge 1 commit intoProject-Sloth:mainfrom
simsonas86 wants to merge 1 commit intoProject-Sloth:mainfrom
Conversation
- Introduce `settingsService` for handling color configurations - Simplify and modularize color loading and application logic - Update `authService` to improve permission and job type management - Remove redundant `loadColorConfig` logic from multiple components and pages
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes summary:
settingsServicefor central settings configuration (only colours currently).authServiceto delegate color configuration tosettingsService.This solves an issue where previously multiple fetchNui requests were sent for
getColorConfigandgetMyPermissionscallbacks at nearly the same time causing some to timeout.P.S. Will probably move more/all settings-related things into the central settings service, just haven't got around to it yet.