fix(utils): stop returning mockData on timeout#541
Open
simsonas86 wants to merge 2 commits intoProject-Sloth:mainfrom
Open
fix(utils): stop returning mockData on timeout#541simsonas86 wants to merge 2 commits intoProject-Sloth:mainfrom
simsonas86 wants to merge 2 commits intoProject-Sloth:mainfrom
Conversation
Removed the ability to return mockData after catching an error entirely.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes summary:
fetchNuito never return mockData from thecatchblock.fetchNuitiming out. (Solved in feat(services): refactor auth and color configuration flow #540).mockDatastill gets returned whenisEnvBrowseris true, but it's handled in the maintryblock instead of when a request times out and is caught. This prevents unwanted behaviour like a permission bypass ifmockDatacontains{ isBoss: true }e.g.ps-mdt/web/src/services/authService.svelte.ts
Lines 211 to 227 in 6bc7b40