Skip to content

GEOPY-2714: Refactor extent property calculation for all grid objects#369

Merged
benk-mira merged 4 commits intodevelopfrom
GEOPY-2714
Apr 2, 2026
Merged

GEOPY-2714: Refactor extent property calculation for all grid objects#369
benk-mira merged 4 commits intodevelopfrom
GEOPY-2714

Conversation

@domfournier
Copy link
Copy Markdown
Collaborator

@domfournier domfournier commented Mar 31, 2026

GEOPY-2714 - Refactor extent property calculation for all grid objects

Copilot AI review requested due to automatic review settings March 31, 2026 19:09
@github-actions github-actions bot changed the title GEOPY-2714 GEOPY-2714: Refactor extent property calculation for all grid objects Mar 31, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates extent/windowing utilities used when masking vertices/cells (notably for topography windowing against mesh bounds), removes the now-unused octree_extents helper, and aligns unit tests with the new extent representation.

Changes:

  • Remove octree_extents utility and its associated test.
  • Update mask_vertices_and_cells to rely on geoh5py.shared.utils.mask_by_extent and accept an extent array (as used by mesh.entity.extent).
  • Update topography masking to pass mesh.entity.extent directly, and adjust tests accordingly.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
simpeg_drivers/utils/utils.py Reworks extent masking implementation and removes octree_extents.
simpeg_drivers/components/topography.py Switches topography windowing to use mesh.entity.extent directly.
tests/utils_test.py Drops octree_extents test and updates extent shape in mask_vertices_and_cells tests.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 1, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.85%. Comparing base (898927a) to head (5a89022).
⚠️ Report is 5 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #369      +/-   ##
===========================================
- Coverage    89.86%   89.85%   -0.01%     
===========================================
  Files          125      125              
  Lines         6425     6419       -6     
  Branches       793      793              
===========================================
- Hits          5774     5768       -6     
  Misses         448      448              
  Partials       203      203              
Files with missing lines Coverage Δ
simpeg_drivers/components/topography.py 93.54% <ø> (-0.11%) ⬇️
simpeg_drivers/utils/utils.py 70.07% <100.00%> (-0.52%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@benk-mira benk-mira merged commit 781475a into develop Apr 2, 2026
19 checks passed
@benk-mira benk-mira deleted the GEOPY-2714 branch April 2, 2026 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants