Added accessibility and docs support to tool listing page#614
Open
brendanx67 wants to merge 3 commits intorelease25.11-SNAPSHOTfrom
Open
Added accessibility and docs support to tool listing page#614brendanx67 wants to merge 3 commits intorelease25.11-SNAPSHOTfrom
brendanx67 wants to merge 3 commits intorelease25.11-SNAPSHOTfrom
Conversation
* Added visually-hidden tool name to Download and Documentation buttons * Show Documentation button when tool has docs extracted from ZIP Co-Authored-By: Claude <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Updates the Skyline Tool Store listing page to better support accessibility and to surface “Online Documentation” when HTML docs are available for a tool (consistent with the tool details page behavior added in #610).
Changes:
- Adds screen-reader-only tool names to Download/Documentation button labels.
- Adds a Documentation button (or dropdown entry) on the listing page when
tool.hasDocumentation()is true. - Adjusts listing-page logic to treat “online docs” as an additional documentation item alongside supplementary files.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
SkylineToolsStore/src/org/labkey/skylinetoolsstore/view/SkylineToolsStoreWebPart.jsp
Show resolved
Hide resolved
SkylineToolsStore/src/org/labkey/skylinetoolsstore/view/SkylineToolsStoreWebPart.jsp
Outdated
Show resolved
Hide resolved
SkylineToolsStore/src/org/labkey/skylinetoolsstore/view/SkylineToolsStoreWebPart.jsp
Outdated
Show resolved
Hide resolved
SkylineToolsStore/src/org/labkey/skylinetoolsstore/view/SkylineToolsStoreWebPart.jsp
Show resolved
Hide resolved
- Added display:inline-flex; and align-items:center; to styled-button CSS class for consistent appearance with <button>
vagisha
approved these changes
Mar 18, 2026
* Converted Download <button> to <a> using link() builder for consistency * Added a.styled-button CSS for text-decoration and visited color * Moved space into visually-hidden span as to prevent collapsing Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tool.hasDocumentation()), consistent with the docs link added to the tool details page in Added documentation support to Skyline Tool Store #610Test plan
Co-Authored-By: Claude noreply@anthropic.com