Skip to content

use trusted publishing for dev releases#310

Merged
IlyasShabi merged 2 commits intomainfrom
ishabi/dev-publish
Apr 1, 2026
Merged

use trusted publishing for dev releases#310
IlyasShabi merged 2 commits intomainfrom
ishabi/dev-publish

Conversation

@IlyasShabi
Copy link
Copy Markdown

What does this PR do?:
Fix dev publish action by using OIDC similar to tag releases

Motivation:

Failed main action: https://github.com/DataDog/pprof-nodejs/actions/runs/23505573240/job/69495441193

@IlyasShabi IlyasShabi added the semver-patch Bug or security fixes, mainly label Apr 1, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 1, 2026

Overall package size

Self size: 2.01 MB
Deduped: 2.37 MB
No deduping: 2.37 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | source-map | 0.7.6 | 185.63 kB | 185.63 kB | | pprof-format | 2.2.1 | 163.06 kB | 163.06 kB | | node-gyp-build | 3.9.0 | 8.81 kB | 8.81 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@IlyasShabi IlyasShabi marked this pull request as ready for review April 1, 2026 09:20
r1viollet
r1viollet previously approved these changes Apr 1, 2026
Copy link
Copy Markdown

@r1viollet r1viollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@IlyasShabi
Copy link
Copy Markdown
Author

@codex review

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: fab9fd12b8

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +51 to +52
permissions:
id-token: write
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Restore read access when enabling OIDC permissions

This job now sets permissions to only id-token: write, which revokes all other GITHUB_TOKEN scopes by default; GitHub docs note unspecified scopes become none, and actions/checkout recommends contents: read for proper operation. In environments where anonymous repository reads are not available (for example private repos or stricter org token policies), the checkout/download path in this job can fail with authorization errors before npm publish runs, so contents: read should be added back alongside id-token: write.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown

@r1viollet r1viollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@IlyasShabi IlyasShabi merged commit f207df1 into main Apr 1, 2026
67 checks passed
@IlyasShabi IlyasShabi deleted the ishabi/dev-publish branch April 1, 2026 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

semver-patch Bug or security fixes, mainly

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants