Open
Conversation
35a893a to
097ac19
Compare
097ac19 to
1410323
Compare
r1viollet
reviewed
Apr 1, 2026
| { | ||
| "regular_expression": "processTimers;listOnTimeout;work;b;slice", | ||
| "percent": 66, | ||
| "percent": 50, |
Collaborator
There was a problem hiding this comment.
why is this changing to 50 50 ?
Author
There was a problem hiding this comment.
These are the observed values and reflect exactly what the code is doing. When back to 60 I had from CI
Assertion failed: stack 'processTimers;listOnTimeout;work;b;slice' (labels=[]) should have been 66% +/- 5% of the profile but was 50% with 16% error
Assertion failed: stack 'processTimers;listOnTimeout;work;a;slice' (labels=[]) should have been 33% +/- 5% of the profile but was 49% with 16% error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
node_heaptest started failing after dd-trace-js changed profiler startup to happen earlier, during tracer initialization.References:
TypeError: mapper.loadDirectory is not a functionand the issue turned out to be a version mismatch. The package dd-trace is installed from master branch, but @datadog/pprof was overridden to "dev" which is an npm dist-tag, not a git branch, and it was resolving to an older pre-release build6.0.0-pre-fdd7f20rather than the current main branch.The pprof pipeline to publish dev was fixed use trusted publishing for dev releases pprof-nodejs#310 and use release publisher file to release dev tag too pprof-nodejs#311