chore: Upgrade Kotlin side to match YouVersion Kotlin SDK 1.0.1#41
chore: Upgrade Kotlin side to match YouVersion Kotlin SDK 1.0.1#41sidorchukandrew wants to merge 7 commits intomainfrom
Conversation
bbb2e6f to
47a6d7c
Compare
310c869 to
60270f8
Compare
|
@greptileai, can you please review this PR? |
Greptile SummaryThis PR upgrades the YouVersion Kotlin SDK from 0.6.0 to 1.0.1 and adapts to Expo 55's new Confidence Score: 5/5Safe to merge — all remaining findings are minor cleanup (P2). The only open finding is a leftover unused android/src/main/java/com/youversion/reactnativesdk/api/YVPBibleApi.kt — unused import on line 3. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A["versions() / languages()"] --> B["do-while pagination loop"]
B --> C["YouVersionApi.bible.versions(pageToken)"]
C --> D{"nextPageToken != null?"}
D -- yes --> C
D -- no --> E["Return allResults"]
F["chapter()"] --> G["Build passageId\nbookUSFM + '.' + chapter"]
G --> H["YouVersionApi.bible.passage(versionId, passageId)"]
H --> I["Return response.content"]
J["SignInWithYouVersionButton.tsx"] --> K{"Platform.OS"}
K -- ios --> L["IosHost"]
K -- android --> M["AndroidHost"]
L --> N["NativeView (SignInWithYouVersionButton)"]
M --> N
O["BibleReaderView.tsx"] --> P{"Platform.OS"}
P -- ios --> Q["IosHost"]
P -- android --> R["AndroidHost"]
Q --> S["NativeView (BibleReaderView)"]
R --> S
Reviews (4): Last reviewed commit: "fixup! chore: update UI views to use Exp..." | Re-trigger Greptile |
android/src/main/java/com/youversion/reactnativesdk/api/YVPBibleApi.kt
Outdated
Show resolved
Hide resolved
43cd979 to
091d2a4
Compare
camrun91
left a comment
There was a problem hiding this comment.
This looks good to me.
Description
This PR does 2 things:
Type of Change
feat:New feature (non-breaking change which adds functionality)fix:Bug fix (non-breaking change which fixes an issue)docs:Documentation updaterefactor:Code refactoring (no functional changes)perf:Performance improvementtest:Test additions or updatesbuild:Build system or dependency changesci:CI configuration changeschore:Other changes (maintenance, etc.)Checklist