YPE-1919: Fix overflow issues on mobile for Bible Reader toolbar and Popovers#209
YPE-1919: Fix overflow issues on mobile for Bible Reader toolbar and Popovers#209cameronapak wants to merge 6 commits intomainfrom
Conversation
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: 110793b The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Greptile SummaryThis PR fixes mobile horizontal overflow for the Confidence Score: 5/5Safe to merge; all findings are P2 style suggestions with no functional regressions. The overflow fix uses well-established Radix collision-padding and standard Tailwind responsive utilities, the semantic token rename is consistent throughout including tests, and the unified changeset is correctly structured. The only finding is a minor sizing inconsistency between the prev/next chapter buttons that has no crash risk. No files require special attention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[Screen width] --> B{Breakpoint check}
B -- "less than sm 640px" --> C[Toolbar: max-w calc 100vw minus 2rem]
B -- "sm or wider" --> D[Toolbar: max-w-lg 512px]
C --> E[Popover: max-w calc 100vw minus 2rem]
D --> F[Popover: w-sm 384px max-w-sm]
E --> G[Radix collisionPadding 16px auto-repositions near edges]
F --> G
G --> H[No horizontal overflow on mobile]
Reviews (4): Last reviewed commit: "Update changeset message" | Re-trigger Greptile |
Adjusted styling for font selection buttons in the bible reader component to improve visual consistency and responsiveness. Also updated popover component to use a smaller default width on small screens.
Adjusted the layout of the Bible reader toolbar to improve responsiveness and visual presentation. This includes changes to grid structures, max-width calculations, and element sizing for better adaptability across different screen sizes.
Refactor the Bible reader toolbar to improve its visual appearance and responsiveness. This includes adjusting grid column definitions, button variants, and min-width properties for better text handling and overall layout.
|
Hey Jared, I'd like to request a review from you on this. I've created a brief overview video that should help get you up to speed |
| variant="secondary" | ||
| variant="ghost" |
There was a problem hiding this comment.
note: this is intentional since the parent bg of this grouped button is the button color
| variant="secondary" | ||
| variant="ghost" |
There was a problem hiding this comment.
note: this is intentional since the parent bg of this grouped button is the button color
Watch Video Overview
Made popovers fit within the mobile view and not overflow off the screen. Affects all popovers: Reader Settings, Bible Version Picker, Bible Chapter Picker, User Menu.
Fixes overflow issues on small screens for when the user has a really long Bible book name or long Bible Version name. See video for more details.
Completes YPE-1919