Set effective_srate to 0 for empty streams when JitterRemoval is off#2
Set effective_srate to 0 for empty streams when JitterRemoval is off#2arnodelorme merged 3 commits intoxdf-modules:masterfrom
Conversation
|
Please also see sccn/xdf#14 What does this change do when streams have no nominal_rate? |
|
Not sure how it affects other downstream functions, but this change does not affect Regardless of the change, a stream without a sccn/xdf#14 is actually better though since Jérémy added some warning messages. |
|
Do you mind testing those changes for me and seeing if it (a) works and (b) fixes your problem? I'd like to merge it but unfortunately I can't test. Actually merging in that repo won't work since we split up the repos, so a new pull request is needed here. |
copied from @jfrey-xx
|
I used xdfBrowser to change a 'healthy' stream's nominal_srate to 0. This file actually did not crash I'm not sure the proper git workflow for copying someone's commit when a repo has been split... |
when JitterRemoval is off
Currently empty streams crash load_xdf when
opts.HandleJitterRemoval = 0, sincetemp(k).time_stampsis empty and the index is out of range.