Fix deprecated datetime.utcnow() calls#84
Open
MichaelMVS wants to merge 2 commits intoxaitax:mainfrom
Open
Conversation
- Replace datetime.datetime.utcnow() with timezone-aware datetime.datetime.now(datetime.timezone.utc) in utils.py - Fix missing import datetime and import pathlib in importers/__init__.py (pathlib.Path was used without import, encoding= was wrong positional arg)
There was a problem hiding this comment.
Pull request overview
Updates SploitScan’s timestamp and directory-import logic to avoid deprecated/incorrect APIs (notably datetime.datetime.utcnow() in newer Python versions and an invalid pathlib.Path(...) usage).
Changes:
- Replaced
datetime.datetime.utcnow()with a timezone-awaredatetime.datetime.now(datetime.timezone.utc)in filename generation. - Fixed directory import globbing by switching to
Path(dir_path).glob("**/*")and adding required imports.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
sploitscan/utils.py |
Uses a timezone-aware UTC timestamp to avoid deprecated utcnow() while keeping the same ...Z filename format. |
sploitscan/importers/__init__.py |
Fixes invalid pathlib.Path(..., encoding=...) usage by using Path(dir_path) and adds necessary imports. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed deprecated
datetime.datetime.utcnow()calls which are deprecated in Python 3.12+ and will be removed in a future version.Changes
sploitscan/utils.py - Replaced
datetime.datetime.utcnow()with timezone-awaredatetime.datetime.now(datetime.timezone.utc)ingenerate_filename().sploitscan/importers/init.py - Added missing
import datetimeandimport pathlib. Thepathlib.Path()was used without importingpathlib, and theencoding=keyword argument was incorrectly passed as a positional argument instead of usingPath(dir_path)correctly.