Skip to content

fix runmap with exe override #1147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Frotty merged 1 commit into from
Feb 26, 2026
Merged

fix runmap with exe override #1147

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion de.peeeq.wurstscript/src/main/java/de/peeeq/wurstio/languageserver/requests/MapRequest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ public MapRequest(WurstLanguageServer langServer, Optional<File> map, List<Strin
this.runArgs = new RunArgs(compileArgs);
this.wc3Path = wc3Path;
if (gameExePath.isPresent() && StringUtils.isNotBlank(gameExePath.get())) {
this.w3data = new W3InstallationData(Optional.of(new File(gameExePath.get())), Optional.of(GameVersion.VERSION_1_29));
this.w3data = new W3InstallationData(Optional.of(new File(gameExePath.get())), Optional.empty());
} else {
this.w3data = getBestW3InstallationData();
}
Expand Down
8 changes: 8 additions & 0 deletions de.peeeq.wurstscript/src/main/java/de/peeeq/wurstio/utils/W3InstallationData.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,14 @@ public W3InstallationData(Optional<File> gameExe, Optional<GameVersion> version)
this.languageServer = null;
this.gameExe = gameExe;
this.version = version;
if (!this.version.isPresent() && this.gameExe.isPresent()) {
try {
this.version = Optional.ofNullable(GameExe.getVersion(this.gameExe.get()));
WLogger.info("Parsed game version from configured executable: " + this.version);
} catch (IOException e) {
WLogger.warning("Could not parse game version from configured executable", e);
}
}
}

/** Evaluates the game path and version by discovering the system environment. */
Expand Down
Loading