Skip to content

Fix sprintf(): Too few arguments when color tokens appear in a sprintf format string #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
swissspidy merged 3 commits into from
Mar 2, 2026
+19 −1
Merged

Fix sprintf(): Too few arguments when color tokens appear in a sprintf format string #197

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
894bc74
Initial plan
Copilot Mar 2, 2026
a45e558
Fix sprintf(): Too few arguments when color tokens in format string a…
Copilot Mar 2, 2026
26a878e
Update inline comment to reflect color token normalization before spr…
Copilot Mar 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion lib/cli/Streams.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,9 +41,11 @@ public static function render( $msg ) {

// If the first argument is not an array just pass to sprintf
if( !is_array( $args[1] ) ) {
// Colorize the message first so sprintf doesn't bitch at us
// Normalize color tokens before sprintf: colorize or strip them so no raw %tokens reach sprintf
if ( Colors::shouldColorize() ) {
$args[0] = Colors::colorize( $args[0] );
} else {
$args[0] = Colors::decolorize( $args[0] );
}

// Escape percent characters for sprintf
Expand Down
16 changes: 16 additions & 0 deletions tests/Test_Cli.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -553,4 +553,20 @@ function test_safe_strlen() {
mb_detect_order( $mb_detect_order );
}
}

function test_render_with_color_tokens_and_sprintf_args_colors_disabled() {
Colors::disable( true );

// Color tokens in format string must not cause "sprintf(): Too few arguments".
$result = \cli\render( '[%C%k%s%N] Starting!', '2024-01-01 12:00:00' );
$this->assertSame( '[2024-01-01 12:00:00] Starting!', $result );
}

function test_render_with_color_tokens_and_sprintf_args_colors_enabled() {
Colors::enable( true );

$result = \cli\render( '[%C%k%s%N] Starting!', '2024-01-01 12:00:00' );
$this->assertStringContainsString( '2024-01-01 12:00:00', $result );
$this->assertStringContainsString( 'Starting!', $result );
}
}