Open
Conversation
Depends on wolfSSL/osp#327
Contributor
There was a problem hiding this comment.
Pull request overview
Extends the OpenSSH CI workflow matrix to include testing against OpenSSH 10.2p1.
Changes:
- Add a new matrix entry for OpenSSH
10.2p1using git refV_10_2_P1. - Reuse the same
SKIP_LTESTSlist for the new OpenSSH version.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
69
to
+76
| SKIP_LTESTS: >- | ||
| exit-status rekey multiplex forward-control channel-timeout | ||
| connection-timeout | ||
| - git_ref: 'V_10_2_P1' | ||
| osp_ver: '10.2p1' | ||
| SKIP_LTESTS: >- | ||
| exit-status rekey multiplex forward-control channel-timeout | ||
| connection-timeout |
There was a problem hiding this comment.
The SKIP_LTESTS block is duplicated verbatim across matrix entries. In GitHub Actions YAML you can reduce duplication by defining this list once (e.g., as a global env: value, or via a YAML anchor/alias) and reusing it for each matrix item. This makes future updates less error-prone when the skip list changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on wolfSSL/osp#327