-
Notifications
You must be signed in to change notification settings - Fork 38
Rewrite tests to python for windows runtime testing #215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
julek-wolfssl
wants to merge
11
commits into
wolfSSL:main
Choose a base branch
from
julek-wolfssl:windows-ci
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
db30ae8
windows setup
julek-wolfssl cb5d98a
Add SM3 hash type in wolfCLU_CertSign function
julek-wolfssl d730ccf
Rewrite tests into python scripts for easier portability
julek-wolfssl 75e45d1
Run tests in windows CI
julek-wolfssl 2b1c91c
Undef CRL_REASON_* because it clashes with other definitions
julek-wolfssl b28b79d
Fix test failures
julek-wolfssl be40be0
Consolidate CI workflows and update action versions
julek-wolfssl f48af1a
Clean up Windows CI workflow and VS project files
julek-wolfssl 28939d3
Use vswhere to detect PlatformToolset
julek-wolfssl 4847855
Fix test failures
julek-wolfssl f5d97d0
Address code review
julek-wolfssl File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| # Ensure cert/key files always use LF line endings so that hashes | ||
| # remain consistent across platforms. | ||
| *.pem eol=lf | ||
| *.cnf eol=lf | ||
| *.cfg eol=lf | ||
|
|
||
| # DER files are binary and must never be transformed. | ||
| *.der binary |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,75 @@ | ||
| name: CI | ||
|
|
||
| on: | ||
| push: | ||
| branches: ['*'] | ||
| pull_request: | ||
| branches: ['*'] | ||
|
|
||
| jobs: | ||
| build: | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| os: [ubuntu-latest, macos-latest] | ||
| config: | ||
| - '--enable-wolfclu' | ||
| - '--enable-wolfclu --enable-crl --enable-dsa --enable-pkcs7' | ||
| - '--enable-wolfclu --enable-smallstack' | ||
| - '--enable-wolfclu --enable-experimental --enable-dilithium' | ||
| - '--enable-wolfclu --enable-smallstack --enable-experimental --enable-dilithium' | ||
| - '--enable-all' | ||
| sanitize: ['', 'CC="cc -fsanitize=address"'] | ||
|
|
||
| name: ${{ matrix.os }} ${{ matrix.sanitize && 'ASAN' || '' }} (${{ matrix.config }}) | ||
| runs-on: ${{ matrix.os }} | ||
| timeout-minutes: 10 | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| with: | ||
| path: wolfclu | ||
|
|
||
| - uses: actions/checkout@v4 | ||
| with: | ||
| repository: wolfssl/wolfssl | ||
| ref: master | ||
| path: wolfssl | ||
|
|
||
| - name: Install dependencies (Ubuntu) | ||
| if: runner.os == 'Linux' | ||
| run: | | ||
| export DEBIAN_FRONTEND=noninteractive | ||
| sudo apt-get update | ||
| sudo apt-get install -y openssl | ||
|
|
||
| - name: Install dependencies (macOS) | ||
| if: runner.os == 'macOS' | ||
| run: brew install automake libtool | ||
|
|
||
| - name: Build and install wolfSSL | ||
| working-directory: ./wolfssl | ||
| run: | | ||
| ./autogen.sh | ||
| ./configure ${{ matrix.config }} ${{ matrix.sanitize }} --prefix=$GITHUB_WORKSPACE/build-dir | ||
| make -j | ||
| make install | ||
|
|
||
| - name: Build wolfCLU | ||
| working-directory: ./wolfclu | ||
| run: | | ||
| ./autogen.sh | ||
| ./configure ${{ matrix.sanitize }} --with-wolfssl=$GITHUB_WORKSPACE/build-dir | ||
| make -j | ||
|
|
||
| - name: Run tests | ||
| working-directory: ./wolfclu | ||
| env: | ||
| LD_LIBRARY_PATH: ${{ github.workspace }}/build-dir/lib | ||
| DYLD_LIBRARY_PATH: ${{ github.workspace }}/build-dir/lib | ||
| run: make check | ||
|
|
||
| - name: Display log | ||
| if: always() | ||
| working-directory: ./wolfclu | ||
| run: cat test-suite.log || true |
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -40,3 +40,8 @@ src/stamp-h1 | |
| .project | ||
| .settings/ | ||
| AGENTS.md | ||
| Win32/ | ||
| x64/ | ||
| .vs/ | ||
| __pycache__/ | ||
| CLAUDE.md | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Toolset detection maps VS major version 18 -> v144, but the checked-in wolfCLU.vcxproj hard-codes v145. If the toolset mapping changes or $ts resolves to $null (unexpected VS version), MSBuild will fail or build with a different toolset than the project file. Consider making the project file use the default toolset and/or adding a fallback/error if $ts is empty.