Fix to ensure support for both Livewire v3 and v4#5
Merged
PhiloNL merged 1 commit intowire-elements:mainfrom Mar 12, 2026
Merged
Fix to ensure support for both Livewire v3 and v4#5PhiloNL merged 1 commit intowire-elements:mainfrom
PhiloNL merged 1 commit intowire-elements:mainfrom
Conversation
First appeared in wire-elements#4
Contributor
|
Perfect, thanks @h4or for the quick fix 🙏 |
Contributor
Author
|
@PhiloNL happy to help :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4
Problem
Version 2.0.1 added support for Livewire 4 by changing the
call()method signature inSupportSignedActionsto accept 5 parameters ($method,$params,$returnEarly,$metadata,$componentContext). However, Livewire 3'sComponentHookonly passes 3 arguments tocall(), resulting in:This breaks all Livewire 3 applications that update to livewire-strict 2.0.1.
Fix
Made
$metadataand$componentContextoptional by defaulting them tonull. Since neither parameter is used in the method body, this is safe and maintains compatibility with both Livewire 3 (3 args) and Livewire 4 (5 args).