Prevent unclear Elasticsearch alias update failures when response is malformed#1060
Merged
rosalieper merged 1 commit intomainfrom Feb 27, 2026
Merged
Prevent unclear Elasticsearch alias update failures when response is malformed#1060rosalieper merged 1 commit intomainfrom
rosalieper merged 1 commit intomainfrom
Conversation
…malformed Add explicit check for missing "acknowledged" key in Elasticsearch response Bug: T418143
tarrow
approved these changes
Feb 27, 2026
Contributor
tarrow
left a comment
tarrow
left a comment
There was a problem hiding this comment.
looks good. We tested this together in a k8s environment. We struggled to get this job to run in docker compose. We tested not only that it now fails with a more informative message if the index is missing but also that it still works properly if the index is present.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add explicit check for missing "acknowledged" key in Elasticsearch response
Bug: T418143