chore: clean cancelled read requests earlier in driver state transitions#6382
Open
caicancai wants to merge 2 commits intovortex-data:developfrom
Open
chore: clean cancelled read requests earlier in driver state transitions#6382caicancai wants to merge 2 commits intovortex-data:developfrom
caicancai wants to merge 2 commits intovortex-data:developfrom
Conversation
Signed-off-by: cancaicai <2356672992@qq.com>
Merging this PR will not alter performance
Comparing Footnotes
|
robert3005
approved these changes
Feb 13, 2026
Contributor
|
Apologies for the delay, since we made some CI changes you will need to rebase to get this merged |
Contributor
Author
@robert3005 Thanks, I performed a merge; will that solve the problem? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handle cancelled reads earlier in on_event (Request/Polled) and keep requests_by_offset in sync when cancellation is detected before poll promotion.
Purpose
When read futures are dropped quickly around registration/poll transition, cancelled requests no longer linger in internal state. This reduces stale index entries, avoids repeated coalescing scans over requests that will never run, and keeps queue/index state more consistent without changing existing dequeue/coalescing correctness checks.