Skip to content

chore: clean cancelled read requests earlier in driver state transitions#6382

Open
caicancai wants to merge 2 commits intovortex-data:developfrom
caicancai:fix/read-early-cancel-cleanup
Open

chore: clean cancelled read requests earlier in driver state transitions#6382
caicancai wants to merge 2 commits intovortex-data:developfrom
caicancai:fix/read-early-cancel-cleanup

Conversation

@caicancai
Copy link
Contributor

Handle cancelled reads earlier in on_event (Request/Polled) and keep requests_by_offset in sync when cancellation is detected before poll promotion.

Purpose
When read futures are dropped quickly around registration/poll transition, cancelled requests no longer linger in internal state. This reduces stale index entries, avoids repeated coalescing scans over requests that will never run, and keeps queue/index state more consistent without changing existing dequeue/coalescing correctness checks.

@codspeed-hq
Copy link

codspeed-hq bot commented Feb 10, 2026

Merging this PR will not alter performance

✅ 1135 untouched benchmarks
⏩ 1268 skipped benchmarks1


Comparing caicancai:fix/read-early-cancel-cleanup (c771915) with develop (6b5a92d)

Open in CodSpeed

Footnotes

  1. 1268 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@joseph-isaacs joseph-isaacs added the action/benchmark Trigger full benchmarks to run on this PR label Feb 10, 2026
@robert3005 robert3005 added the changelog/performance A performance improvement label Feb 10, 2026
@robert3005
Copy link
Contributor

Apologies for the delay, since we made some CI changes you will need to rebase to get this merged

@caicancai
Copy link
Contributor Author

Apologies for the delay, since we made some CI changes you will need to rebase to get this merged

@robert3005 Thanks, I performed a merge; will that solve the problem?

@robert3005 robert3005 added action/benchmark Trigger full benchmarks to run on this PR and removed action/benchmark Trigger full benchmarks to run on this PR labels Feb 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action/benchmark Trigger full benchmarks to run on this PR changelog/performance A performance improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants