fix(ci): include man page in generated Homebrew formula#101
Merged
Conversation
The update-homebrew job template was missing the resource "man" block and the man1.install call, so the man page was never installed via brew. Closes #100
vmvarela
added
type:bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
update-homebrewjob inrelease.ymlgenerates the Homebrew formula from an inline template but was missing theresource "man"block and theman1.installcall.brew install sql-pipeinstalled the binary but not the man page.sql-pipe.1.gzand patches the template to include the man page resource and its installation.Changes
SHA_MANfromartifacts/sql-pipe.1.gzalongside the binary hashes.resource "man"block to the formula template with__SHA_MAN__placeholder.resource("man").stage { man1.install "sql-pipe.1.gz" }to theinstallblock.sedsubstitution for__SHA_MAN__.Closes #100