Fixed an Unhandled exception due to long Windows file path #36
Open
pradyumnac wants to merge 2 commits intovisualcurrent:masterfrom
Open
Fixed an Unhandled exception due to long Windows file path #36pradyumnac wants to merge 2 commits intovisualcurrent:masterfrom
pradyumnac wants to merge 2 commits intovisualcurrent:masterfrom
Conversation
For each version of python, the earlier gitignore would not work 2. Added gitignore entry for virtualenv folder 3. Added requiremnents file for easy install through pip
…erred Issue is due to long windows path
Author
|
#33 A follow up fix for This PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original issue. This is due to windows long path limitation
This fix addresses an unhandled "FileNotFound" exception in the situation that the temporary extract file path length is too long for windows and was silently not getting extracted
Solution:
To ignore such error but keep a track of such files separately and print out these error at the end
The ProblemFiles.MD mechanism captures these unhandled filepaths in the log
A. Modification to N2O.py to handle a file open where fil was not being found. This is due to windows long path limitation
B. Also added pip requirements.txt file for easy virtyual env suport
C. Modified Gitignore
Otherwise, the .pyc cache file for each new python version will be pulled into repo