Merged
Conversation
and remove artifact left over from debugging
Also, some improvements to exceptions, and cleanup of unneeded code
Note: We have less python infix failures after last fix!
jcschaff
requested changes
Feb 26, 2026
Member
jcschaff
left a comment
jcschaff
left a comment
There was a problem hiding this comment.
Hi Logan - nice job. please address my comments.
vcell-math/src/main/java/cbit/vcell/parser/ExpressionUtils.java
Outdated
Show resolved
Hide resolved
vcell-math/src/main/java/cbit/vcell/parser/ParserException.java
Outdated
Show resolved
Hide resolved
vcell-math/src/test/reports/pythonInfixTest_seed_1772035787937__4980_outOf_5000.txt
Show resolved
Hide resolved
CodeByDrescher
commented
Feb 26, 2026
Contributor
Author
CodeByDrescher
left a comment
CodeByDrescher
left a comment
There was a problem hiding this comment.
Changes either implemented, or directly discussed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Step 1 of getting PyVCell to support infix notation in python directly.