Add get_numeric_columns method in VMDataset to get list of all numeric columns#485
Open
AnilSorathiya wants to merge 1 commit intomainfrom
Open
Conversation
Contributor
PR SummaryThis pull request introduces a new method, get_numeric_columns, in the DataFrameDataset class, which extracts all numeric columns from a given pandas DataFrame. Unlike the existing feature_columns_numeric attribute that only considers feature columns, the new method returns every column with a numeric datatype (including target and other extra columns). Key changes include:
These changes enhance the robustness of column type identification within the dataset, enabling more flexible downstream processing. Test Suggestions
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
What and why?
Add a way to get all numeric columns from a
VMDataset(not only feature columns)get_numeric_columns()onVMDataset:pd.api.types.is_numeric_dtype).self._df), so it includes all numeric columns (target, extra columns, prediction/probability columns, etc.), not only feature columns.How to test
New test:
test_get_numeric_columnsinTestTabularDataset:What needs special review?
Dependencies, breaking changes, and deployment notes
Release notes
Checklist