fix: use PAT instead of GITHUB_TOKEN for release tag workflow#484
fix: use PAT instead of GITHUB_TOKEN for release tag workflow#484
Conversation
Events created by the default GITHUB_TOKEN do not trigger downstream workflows. This prevents the PyPI publish workflow from running when a tag is pushed by the create_release_tag workflow. Switch to a PAT (LIBRARY_RELEASE_PAT) for both the checkout token and gh release create to allow the tag push event to trigger pypi.yaml. Amp-Thread-ID: https://ampcode.com/threads/T-019cb4fe-12f8-7048-886a-f54feb449e88 Co-authored-by: Amp <amp@ampcode.com>
|
Pull requests must include at least one of the required labels: |
PR SummaryThis pull request updates the release creation workflow to use the LIBRARY_RELEASE_PAT secret instead of the default GITHUB_TOKEN in two key areas:
These changes are focused on enhancing the release process by switching to a different secret token, likely to allow improved control over token permissions or to address specific requirements of the release management process. Test Suggestions
|
|
Pull requests must include at least one of the required labels: |
Pull Request Description
What and why?
The
create_release_tagworkflow uses the defaultGITHUB_TOKENto push tags and create releases. GitHub Actions intentionally prevents events created byGITHUB_TOKENfrom triggering other workflows, which means thepypi.yamlworkflow (triggered onpush: tags: v*.*.*) never fires after a tag is created.This PR switches to a PAT (
LIBRARY_RELEASE_PAT) for both the checkout token (used bygit push) and thegh release createstep, allowing downstream workflows to trigger.How to test
LIBRARY_RELEASE_PATrepo secret with a PAT that hascontents: writescopeWhat needs special review?
LIBRARY_RELEASE_PATsecret is created in the repo before mergingDependencies, breaking changes, and deployment notes
LIBRARY_RELEASE_PAT(PAT withcontents: writepermission)Release notes
Checklist