Skip to content

exposed use time metric for a failure a connection as well#28

Merged
abnegate merged 1 commit intomainfrom
use-time-metric
Feb 26, 2026
Merged

exposed use time metric for a failure a connection as well#28
abnegate merged 1 commit intomainfrom
use-time-metric

Conversation

@ArnabChatterjee20k
Copy link
Contributor

@ArnabChatterjee20k ArnabChatterjee20k commented Feb 26, 2026

Use time metric wasn't exposing the use time for a error specific connection -> hiding details
So exposed for every use operation

Summary by CodeRabbit

  • Bug Fixes
    • Improved consistency of performance monitoring by ensuring telemetry is recorded uniformly across all database pool operations.

@coderabbitai
Copy link

coderabbitai bot commented Feb 26, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b7d8dd0 and 986b136.

📒 Files selected for processing (1)
  • src/Pools/Pool.php

Walkthrough

The use() method in the Pool class was modified to record telemetry duration unconditionally within the finally block. Previously, the telemetry recording occurred conditionally only when a connection was successfully obtained. This change consolidates the telemetry recording into a single always-executed location, ensuring duration is recorded regardless of connection acquisition status.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: exposing use time metrics for failed connections, which aligns with the core objective of recording telemetry duration unconditionally in the finally block.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch use-time-metric

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@abnegate abnegate merged commit 74de7c5 into main Feb 26, 2026
4 checks passed
@abnegate abnegate deleted the use-time-metric branch February 26, 2026 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants