fix: fallback to docker-container driver when default builder uses docker driver#86
Merged
adityamaru merged 4 commits intomainfrom Mar 27, 2026
Merged
Conversation
…cker driver Co-authored-by: Codesmith <codesmith@blacksmith.sh>
Co-authored-by: Codesmith <codesmith@blacksmith.sh>
Co-authored-by: Codesmith <codesmith@blacksmith.sh>
eltonkl
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the Blacksmith remote builder setup fails and the action falls back to a local builder, it inspects the current builder and reuses it if one exists. However, if the default builder uses the
dockerdriver (which doesn't support attestation or many buildx features), the fallback silently uses an incompatible builder instead of creating one with thedocker-containerdriver.This adds a driver check to the fallback path so that a
docker-driver builder is treated the same as no builder — the action will create a newdocker-containerbuilder in either case.This is the same fix as #76 (credit to @dephiros), re-landed on a maintainer-owned branch so that CI can access the BUF registry token for the npm package fetch.
Note:
dist/index.jswill need to be rebuilt — CI has theBUF_TOKENsecret required to install dependencies and run the build. The verify-build check will flag this; a follow-up commit can update dist once CI confirms the source change is correct.View Codesmith session