Closed
Conversation
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Caching applies to all commands, cf. https://bazel.build/versions/8.0.0/reference/command-line-reference#flag--disk_cache.
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Like BUILD file changes, changes to workspace dependencies can significantly affect the contents of the disk cache. Prior to this change, upreving dependencies wasn't itself sufficient to update the disk cache, resulting in repeatedly rebuilding dependencies until some subsequent commit happened to modify BUILD files.
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…b#123) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…#130) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…b#133) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…ontrib#139) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…#143) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
GitHub have deprecated NodeJS v20 as an environment for actions, and will be using NodeJS v24 for all actions from 2nd June 2026[1]. Currently GitHub runners print a deprecation warning in their logs showing all actions that use the node20 environment, which includes setup-bazel, so I'm updating the action to use node24, and so remove it from the deprecation warning. [1] https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Recent @actions/* modules are ESM, so we need to switch over to ESM as well
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
| import * as github from '@actions/github' | ||
|
|
||
| const bazeliskVersion = core.getInput('bazelisk-version') | ||
| const cacheSave = core.getBooleanInput('cache-save') |
There was a problem hiding this comment.
cacheSave config is exported but never checked
High Severity
The cacheSave property is read from the cache-save input and exported in the config, but config.cacheSave is never checked anywhere in post.js (which handles cache saving via saveCache and saveExternalCaches). This means the documented feature — "Set to false for pull requests to allow cache restoration without saving" — is a complete no-op. Setting cache-save: false will not prevent caches from being saved.
Additional Locations (1)
| const googleCredentialsSaved = (core.getState('google-credentials-path').length > 0) | ||
| if (googleCredentials.length > 0 && !googleCredentialsSaved) { | ||
| const tmpDir = core.toPosixPath(fs.mkdtempSync(os.tmpdir())) | ||
| const tmpDir = core.toPosixPath(fs.mkdtempSync(process.env.RUNNER_TEMP)) |
There was a problem hiding this comment.
mkdtempSync creates temp dir as sibling, not inside
Low Severity
fs.mkdtempSync(process.env.RUNNER_TEMP) appends random characters directly to the prefix. If RUNNER_TEMP is /home/runner/work/_temp, this creates /home/runner/work/_tempXXXXXX (a sibling directory) rather than a subdirectory inside RUNNER_TEMP. A trailing path separator or path.join is needed to create the temp directory inside the intended location.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
16 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
process.env.RUNNER_TEMPinstead ofos.tmpdir()(Fix google_credentials bazel-contrib/setup-bazel#47)BAZELISK_GITHUB_TOKENvariable.exeon windows (add .exe on windows bazel-contrib/setup-bazel#83)