Open
Conversation
andrewmoreno
suggested changes
Jul 15, 2022
3bd8862 to
38ee5d5
Compare
andrewmoreno
approved these changes
Jul 15, 2022
38ee5d5 to
a944870
Compare
| target instanceof Element && | ||
| !ref?.current?.contains(target) | ||
| ) { | ||
| setActive(false); |
Contributor
There was a problem hiding this comment.
Wouldn't this be more beneficial if this was a callback?
Usually a click outside is an action, when we click outside an element, we want to trigger a callback.
For example, a simple modal or a dropdown menu, clicking outside those elements would trigger a close.
Suggested change
| setActive(false); | |
| callback(); |
I'm not seeing a good case for using a state @luisdralves, but maybe you have a more explicit example.
WDYT @rafaelcruzazevedo?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PRs adds the
use-detect-outside-clickhook. It detects if a click is inside or outside a component