Simplify helper methods by using Repository::Owner consistently#97
Merged
tricknotes merged 2 commits intoclaude/xenodochial-engelbartfrom Mar 24, 2026
Merged
Simplify helper methods by using Repository::Owner consistently#97tricknotes merged 2 commits intoclaude/xenodochial-engelbartfrom
tricknotes merged 2 commits intoclaude/xenodochial-engelbartfrom
Conversation
Co-authored-by: tricknotes <290782+tricknotes@users.noreply.github.com> Agent-Logs-Url: https://github.com/tricknotes/starseeker/sessions/88dafe1b-34ea-48bd-b7f5-bf70463355de
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses feedback on #96 to simplify the helper methods in
application_helper.rbthat were handling multiple data type variations (User models, Data objects, and hashes) with complex conditional branching.Changes
image_link_to_github_url: Reduced multi-branch conditional to simple ternary operatoravatar_image_tag: Eliminated middlerespond_to?(:login)branch, now handles only User vs. owner objectsimage_link_to_github_url_from_event: CreatesRepository::OwnerData object instead of passing hashResult
Before:
After:
Type consistency enforced: all owner data now uses
Repository::OwnerData objects with.loginand.avatar_urlmethods.