phpstan level 5 by tijmenbruggeman · Pull Request #48 · tinify/tinify-php

tijmenbruggeman · 2026-03-18T16:12:22Z

added workflow for phpstan analysis.

set current standard to level 5 (https://phpstan.org/user-guide/rule-levels). Level 5 only required one fix
level 6 requires 93 fixes which is to much for this PR
added it as 2nd workflow as it can run independent
targets min version 7

tijmenbruggeman added 4 commits March 18, 2026 17:09

add phpstan

ccad07d

add config for level 4 and php 7

8460635

add workflow

4b3608c

curl_init will never return null

9c4c2a8

tijmenbruggeman marked this pull request as draft March 18, 2026 16:12

tijmenbruggeman marked this pull request as ready for review March 18, 2026 16:24

set level 5, does not throw more errors

9fce863

tijmenbruggeman changed the title ~~phpstan level 4~~ phpstan level 5 Mar 18, 2026

rkoopmans mentioned this pull request Mar 18, 2026

Feature : add phpdoc for return types #45

Closed

Add seperate workflow for phpstan

cc9225a

rkoopmans approved these changes Mar 31, 2026

View reviewed changes

tijmenbruggeman added 2 commits March 31, 2026 20:47

setters return void so no need to return setters

1e514ab

throw error on end of request

a4698c7

rkoopmans merged commit 096f1c1 into tinify:master Apr 1, 2026
17 checks passed

Provide feedback