Skip to content

fix: single quote issue #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
IKKEM-Lin wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: single quote issue #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/index.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,10 +51,12 @@ describe('sqlite-level', () => {
{type: 'del', key: 'key1'},
{type: 'put', key: 'key2', value: 'value2'},
{type: 'put', key: 'key3', value: 'value3'},
{type: 'put', key: "'key4'", value: "Mark's"},
])
await expect(level.get('key1')).rejects.toThrow(keyNotFoundError('key1'))
expect(await level.get('key2')).toEqual('value2')
expect(await level.get('key3')).toEqual('value3')
expect(await level.get("'key4'")).toEqual("Mark's")
})

it('iterates over key value pairs', async () => {
Expand Down
6 changes: 4 additions & 2 deletions src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,10 +284,12 @@ export class SqliteLevel<KDefault = string, VDefault = string> extends AbstractL
curBatch = []
curType = op.type
}
const key = op.key.toString().replace(/'/g, "''");
if (op.type === 'put') {
curBatch.push(`('${op.key.toString()}', '${op.value.toString()}')`)
const value = op.value.toString().replace(/'/g, "''");
curBatch.push(`('${key}', '${value}')`)
} else if (op.type === 'del') {
curBatch.push(`'${op.key.toString()}'`)
curBatch.push(`'${key}'`)
}
}
if (curBatch.length > 0) {
Expand Down