Fix istio ImageSet test names to use version constants#4629
Merged
caseydavenport merged 1 commit intotigera:masterfrom Apr 3, 2026
Merged
Fix istio ImageSet test names to use version constants#4629caseydavenport merged 1 commit intotigera:masterfrom
caseydavenport merged 1 commit intotigera:masterfrom
Conversation
The tests hardcoded "calico-master" and "enterprise-master" as ImageSet names, which breaks on release branches where the version string differs. Use components.CalicoRelease and components.EnterpriseRelease so the names are always correct regardless of branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The istio controller tests were hardcoding
calico-masterandenterprise-masteras ImageSet names, which works on master but breaks on release branches where the version string differs (e.g.,calico-release-v3.32). Switched to usingcomponents.CalicoReleaseandcomponents.EnterpriseReleaseso the names are always correct regardless of branch.