Grant kube-controllers list/watch on daemonsets during migration#4620
Merged
caseydavenport merged 2 commits intotigera:masterfrom Apr 1, 2026
Merged
Conversation
rene-dekker
approved these changes
Apr 1, 2026
caseydavenport
added a commit
to caseydavenport/operator
that referenced
this pull request
Apr 1, 2026
caseydavenport
added a commit
that referenced
this pull request
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The v1->v3 migration controller in kube-controllers sets up a dynamic informer to watch calico-node, so it can detect when the operator has set CALICO_API_GROUP and the rollout completes. This informer needs list/watch on apps/daemonsets, but the migration RBAC ClusterRole didn't include it.
The base kube-controllers ClusterRole already grants get on the calico-node daemonset (scoped via ResourceNames), but list/watch don't work with ResourceNames, so we add them to the migration-specific ClusterRole instead.