Add probe timing overrides to Installation API#4612
Open
caseydavenport wants to merge 1 commit intomasterfrom
Open
Add probe timing overrides to Installation API#4612caseydavenport wants to merge 1 commit intomasterfrom
caseydavenport wants to merge 1 commit intomasterfrom
Conversation
Add ReadinessProbe and LivenessProbe fields of type ProbeOverride to all
container override structs. Users can now tune PeriodSeconds, TimeoutSeconds,
FailureThreshold, and InitialDelaySeconds through the standard deployment
override mechanism without changing the probe handler (which the operator
controls).
The override merge path in components.go is extended to apply probe timing
alongside resource and port overrides via mergeContainerOverrides().
Example usage:
spec:
calicoNodeDaemonSet:
spec:
template:
spec:
containers:
- name: calico-node
readinessProbe:
periodSeconds: 10
timeoutSeconds: 5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds ReadinessProbe and LivenessProbe fields of type ProbeOverride to all container override structs in the Installation API. Users can now tune PeriodSeconds, TimeoutSeconds, FailureThreshold, and InitialDelaySeconds through the standard deployment override mechanism without changing the probe handler (which the operator controls).
Example usage:
The ProbeOverride type only exposes timing parameters — the probe handler itself is always set by the operator. The override merge path in components.go applies probe timing alongside resource and port overrides via
mergeContainerOverrides().