Add probe timing overrides to Installation API#4611
Closed
caseydavenport wants to merge 2 commits intotigera:masterfrom
Closed
Add probe timing overrides to Installation API#4611caseydavenport wants to merge 2 commits intotigera:masterfrom
caseydavenport wants to merge 2 commits intotigera:masterfrom
Conversation
Add ReadinessProbe and LivenessProbe fields of type ProbeOverride to all container override structs in the Installation API. This lets users tune probe PeriodSeconds, TimeoutSeconds, FailureThreshold, and InitialDelaySeconds through the standard deployment override mechanism without changing the probe handler (which the operator controls). The ProbeOverride type is intentionally minimal — it only exposes timing parameters since the operator must control what the probes actually check. Also adds a probes.ApplyOverride() helper in pkg/render/common/probes/ for render functions to apply overrides when constructing probes.
Wire ProbeOverride fields into the container override merge path: - mergeContainerOverrides applies resource, readiness, and liveness probe overrides from the Installation API to rendered containers - valueToContainerOverrides extracts all override fields via reflection - Add DaemonSet test entry verifying probe period/timeout overrides - Add unit tests for probes.ApplyOverride helper - Include gen-files output (CRDs, deepcopy)
Member
Author
|
Recreating with rebased branch on tigera/operator |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds ReadinessProbe and LivenessProbe fields of type ProbeOverride to all container override structs in the Installation API. Users can now tune PeriodSeconds, TimeoutSeconds, FailureThreshold, and InitialDelaySeconds through the standard deployment override mechanism without changing the probe handler (which the operator controls).
Example usage in an Installation resource:
The ProbeOverride type is intentionally minimal — only timing parameters, not the probe handler itself. A helper
probes.ApplyOverride()is provided inpkg/render/common/probes/for render functions to apply overrides.Relates to: #4608