Skip to content

Fix R-devel import conflicts and bump version to 0.4.1#230

Merged
fabian-s merged 3 commits intomainfrom
issue-229-checkmate-imports
Apr 7, 2026
Merged

Fix R-devel import conflicts and bump version to 0.4.1#230
fabian-s merged 3 commits intomainfrom
issue-229-checkmate-imports

Conversation

@fabian-s
Copy link
Copy Markdown
Contributor

@fabian-s fabian-s commented Apr 7, 2026

Summary

Verification

  • -> 1300 passed
  • clean exported build in -> ~/.Rprofile loaded.
  • using log directory ‘/home/fabians/fda/tidyfun-pkgs/tf/.worktrees/issue-229-checkmate-imports/tf.Rcheck’
  • using R version 4.5.2 (2025-10-31)
  • using platform: x86_64-pc-linux-gnu
  • R was compiled by
    gcc (Ubuntu 13.3.0-6ubuntu224.04) 13.3.0
    GNU Fortran (Ubuntu 13.3.0-6ubuntu2
    24.04) 13.3.0
  • running under: Linux Mint 22.1
  • using session charset: UTF-8
  • using option ‘--no-manual’
  • checking for file ‘tf/DESCRIPTION’ ... OK
  • this is package ‘tf’ version ‘0.4.1’
  • package encoding: UTF-8
  • checking package namespace information ... OK
  • checking package dependencies ... OK
  • checking if this is a source package ... OK
  • checking if there is a namespace ... OK
  • checking for executable files ... OK
  • checking for hidden files and directories ... NOTE
    Found the following hidden files and directories:
    .git
    These were most likely included in error. See section ‘Package
    structure’ in the ‘Writing R Extensions’ manual.
  • checking for portable file names ... OK
  • checking for sufficient/correct file permissions ... OK
  • checking whether package ‘tf’ can be installed ... OK
  • checking installed package size ... OK
  • checking package directory ... OK
  • checking DESCRIPTION meta-information ... OK
  • checking top-level files ... OK
  • checking for left-over files ... OK
  • checking index information ... OK
  • checking package subdirectories ... OK
  • checking code files for non-ASCII characters ... OK
  • checking R files for syntax errors ... OK
  • checking whether the package can be loaded ... OK
  • checking whether the package can be loaded with stated dependencies ... OK
  • checking whether the package can be unloaded cleanly ... OK
  • checking whether the namespace can be loaded with stated dependencies ... OK
  • checking whether the namespace can be unloaded cleanly ... OK
  • checking loading without being on the library search path ... OK
  • checking whether startup messages can be suppressed ... OK
  • checking dependencies in R code ... OK
  • checking S3 generic/method consistency ... OK
  • checking replacement functions ... OK
  • checking foreign function calls ... OK
  • checking R code for possible problems ... OK
  • checking Rd files ... OK
  • checking Rd metadata ... OK
  • checking Rd cross-references ... OK
  • checking for missing documentation entries ... OK
  • checking for code/documentation mismatches ... OK
  • checking Rd \usage sections ... OK
  • checking Rd contents ... OK
  • checking for unstated dependencies in examples ... OK
  • checking contents of ‘data’ directory ... OK
  • checking data for non-ASCII characters ... OK
  • checking LazyData ... OK
  • checking data for ASCII and uncompressed saves ... OK
  • checking examples ... OK
  • checking for unstated dependencies in ‘tests’ ... OK
  • checking tests ...
    OK
  • DONE
    Status: 1 NOTE returned
  • devel-focused rhub checks dispatched for this head: , , ()

Closes #229.

Copilot AI review requested due to automatic review settings April 7, 2026 08:47
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses upcoming R-devel namespace import conflicts between rlang and checkmate by switching from blanket checkmate imports to explicit importFrom() directives, and bumps the package version for a CRAN follow-up release.

Changes:

  • Replace import(checkmate) with selective importFrom(checkmate, ...) to avoid new import-replacement warnings on R-devel.
  • Add checkmate loading in the test harness (via tests/testthat.R and a helper).
  • Bump package version to 0.4.1 and document the patch release in NEWS.md / cran-comments.md.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
tests/testthat/helper-checkmate.R Adds test helper to attach checkmate during test runs.
tests/testthat.R Attaches checkmate before running test_check().
R/tf-package.R Switches roxygen tags from @import checkmate to explicit @importFrom checkmate ....
R/print-format.R Documentation markup tweak for tibble::glimpse().
NEWS.md Adds 0.4.1 notes describing the import-conflict fix.
NAMESPACE Removes blanket checkmate import; adds explicit importFrom(checkmate, ...) entries.
man/tfdisplay.Rd Updates generated Rd text consistent with roxygen markup change.
DESCRIPTION Bumps version to 0.4.1.
cran-comments.md Updates CRAN submission notes for the patch release and rationale.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@@ -1,4 +1,5 @@
library(testthat)
library(checkmate)
Copy link

Copilot AI Apr 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checkmate is being attached twice for the test run (here and again in tests/testthat/helper-checkmate.R). Consider keeping only one of these library(checkmate) calls (typically the helper is enough) to avoid redundant attachments and reduce the chance of order-dependent masking effects.

Suggested change
library(checkmate)

Copilot uses AI. Check for mistakes.
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.57%. Comparing base (d9c74c1) to head (66be334).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #230   +/-   ##
=======================================
  Coverage   85.57%   85.57%           
=======================================
  Files          36       36           
  Lines        4360     4360           
=======================================
  Hits         3731     3731           
  Misses        629      629           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@fabian-s fabian-s merged commit 015f182 into main Apr 7, 2026
10 checks passed
@fabian-s fabian-s deleted the issue-229-checkmate-imports branch April 7, 2026 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Namespace conflicts with checkmate for packages using import(rlang) + import(checkmate)

2 participants