Fix R-devel import conflicts and bump version to 0.4.1#230
Conversation
There was a problem hiding this comment.
Pull request overview
This PR addresses upcoming R-devel namespace import conflicts between rlang and checkmate by switching from blanket checkmate imports to explicit importFrom() directives, and bumps the package version for a CRAN follow-up release.
Changes:
- Replace
import(checkmate)with selectiveimportFrom(checkmate, ...)to avoid new import-replacement warnings on R-devel. - Add
checkmateloading in the test harness (viatests/testthat.Rand a helper). - Bump package version to
0.4.1and document the patch release inNEWS.md/cran-comments.md.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/testthat/helper-checkmate.R | Adds test helper to attach checkmate during test runs. |
| tests/testthat.R | Attaches checkmate before running test_check(). |
| R/tf-package.R | Switches roxygen tags from @import checkmate to explicit @importFrom checkmate .... |
| R/print-format.R | Documentation markup tweak for tibble::glimpse(). |
| NEWS.md | Adds 0.4.1 notes describing the import-conflict fix. |
| NAMESPACE | Removes blanket checkmate import; adds explicit importFrom(checkmate, ...) entries. |
| man/tfdisplay.Rd | Updates generated Rd text consistent with roxygen markup change. |
| DESCRIPTION | Bumps version to 0.4.1. |
| cran-comments.md | Updates CRAN submission notes for the patch release and rationale. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -1,4 +1,5 @@ | |||
| library(testthat) | |||
| library(checkmate) | |||
There was a problem hiding this comment.
checkmate is being attached twice for the test run (here and again in tests/testthat/helper-checkmate.R). Consider keeping only one of these library(checkmate) calls (typically the helper is enough) to avoid redundant attachments and reduce the chance of order-dependent masking effects.
| library(checkmate) |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #230 +/- ##
=======================================
Coverage 85.57% 85.57%
=======================================
Files 36 36
Lines 4360 4360
=======================================
Hits 3731 3731
Misses 629 629 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Summary
import(rlang)+import(checkmate)#229 by replacing blanket imports with selective imports to avoid new export conflicts on R-develVerification
gcc (Ubuntu 13.3.0-6ubuntu2
24.04) 13.3.024.04) 13.3.0GNU Fortran (Ubuntu 13.3.0-6ubuntu2
Found the following hidden files and directories:
.git
These were most likely included in error. See section ‘Package
structure’ in the ‘Writing R Extensions’ manual.
OK
Status: 1 NOTE returned
Closes #229.