fix: clear OTel context after span execution#395
Merged
chris-olszewski merged 5 commits intotemporalio:mainfrom Mar 11, 2026
Merged
fix: clear OTel context after span execution#395chris-olszewski merged 5 commits intotemporalio:mainfrom
chris-olszewski merged 5 commits intotemporalio:mainfrom
Conversation
|
|
chris-olszewski
requested changes
Mar 10, 2026
Member
chris-olszewski
left a comment
chris-olszewski
left a comment
There was a problem hiding this comment.
Thanks for the detailed issue and PR. Looks good to me, just need to update the rbs file with the added _detach_contexts
Ensure Context#detach is called after span execution to avoid spans being associated with incorrect traces.
nicobritos
force-pushed
the
fix-otel-attach
branch
from
01bc366 to
b349c46
Compare
Contributor
Author
You are right! Sorry, completely missed that. Should be okay now |
chris-olszewski
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure Context#detach is called after span execution to avoid spans being associated with incorrect traces.
What was changed
Why?
See #394
Checklist
Closes [Bug] OTeL trace context leaking between workflows when threads/fibers are reused #394
How was this tested:
See [Bug] OTeL trace context leaking between workflows when threads/fibers are reused #394 for reproduction.
Also, test were added for this case. Commenting
temporalio/lib/temporalio/contrib/open_telemetry.rb:83should fail the test.