Draft
Conversation
cretz
reviewed
Jul 10, 2025
| /// <summary> | ||
| /// Placeholder. | ||
| /// </summary> | ||
| internal class RootPlugin : Plugin |
Contributor
There was a problem hiding this comment.
Would recommend making this implement the interface w/ a throw NotImplementedException for init
|
|
||
| public TemporalClientOptions OnCreateClient(TemporalClientOptions options); | ||
|
|
||
| public Task<TemporalConnection> TemporalConnectAsync(TemporalClientConnectOptions options); |
Contributor
There was a problem hiding this comment.
Would call this ClientConnectAsync and other ClientCreateLazy
Comment on lines
+13
to
+14
| private IWorkerPlugin? nextWorkerPlugin; | ||
| private IClientPlugin? nextClientPlugin; |
Contributor
There was a problem hiding this comment.
Would recommend these be protected properties, and that they return non-null values and fail if the backing fields are null
Contributor
There was a problem hiding this comment.
Would not recommend putting this in the Interceptors namespace, and would recommend calling this ITemporalClientPlugin (same two things for worker side)
|
|
||
| namespace Temporalio.Common | ||
| { | ||
| public class Plugin : IClientPlugin, IWorkerPlugin |
Contributor
There was a problem hiding this comment.
Mark all methods here as virtual
Comment on lines
+158
to
+161
| public new async Task<TemporalConnection> TemporalConnectAsync(TemporalClientConnectOptions options) | ||
| { | ||
| return await TemporalConnection.ConnectAsync(options).ConfigureAwait(false); | ||
| } |
Contributor
There was a problem hiding this comment.
Suggested change
| public new async Task<TemporalConnection> TemporalConnectAsync(TemporalClientConnectOptions options) | |
| { | |
| return await TemporalConnection.ConnectAsync(options).ConfigureAwait(false); | |
| } | |
| public Task<TemporalConnection> TemporalConnectAsync(TemporalClientConnectOptions options) => | |
| TemporalConnection.ConnectAsync(options); |
Pedantic shortcut
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Why?
Checklist
Closes
How was this tested: