test(spy-server): add tests & verify#307
Draft
stefan-ctrl wants to merge 13 commits intofeat/spy-serverfrom
Draft
test(spy-server): add tests & verify#307stefan-ctrl wants to merge 13 commits intofeat/spy-serverfrom
stefan-ctrl wants to merge 13 commits intofeat/spy-serverfrom
Conversation
…rver dependencies
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
ron96g
requested changes
Apr 1, 2026
Member
ron96g
left a comment
ron96g
left a comment
There was a problem hiding this comment.
I cannot find any tests for the obfuscated secrets "******" (atleast not in the snapshosts). Could you check if this is working and add tests for it?
| @@ -0,0 +1,1367 @@ | |||
|
|
|||
Member
There was a problem hiding this comment.
Can we split this snapshot file? Mayb per controller or something else?
spy-server/internal/config/config.go
Outdated
| // Secrets maps CRD kind names to the JSON field paths within that kind | ||
| // that may contain secret-manager placeholders (e.g. "$<secret-id>"). | ||
| // Only used when SecretManager.Enabled is true. | ||
| Secrets map[string][]string `json:"secrets" yaml:"secrets" mapstructure:"secrets"` |
Member
There was a problem hiding this comment.
what is the benefit of making this configurable?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.