Conversation
Member
ron96g
commented
Mar 24, 2026
ron96g
commented
- refactor(common): migrate error handling from pkg/errors to stdlib errors.As
- refactor(identity): simplify keycloak client and remove grafana dashboards
- refactor(identity): consolidate handlers and improve dependency injection
…rors.As Replace errors.Cause() with errors.As() to properly unwrap error chains created with both pkg/errors.Wrap and fmt.Errorf %w. Add tests for wrapped error scenarios and fix typos (updatd -> updated, deley -> delay). Extract NewBaseHttpClient() from NewHttpClientOrDie() to allow callers to compose additional transports (e.g. OAuth2) before applying metrics.
…oards Refactor keycloak client factory to use NewBaseHttpClient for composable transport setup and improve error classification in client_error.go. Remove custom_metrics.go and kubebuilder grafana plugin config along with all generated dashboard JSONs. Regenerate mocks for updated interfaces.
…tion Merge status.go into handler.go for client, realm, and identityprovider handlers. Inject keycloak.ClientFactory into handlers and controllers instead of creating clients inline. Add field index registration via new index.go and wire it in main.go. Move model defaults from internal/model to internal/testutil/fixtures. Add comprehensive handler unit tests with Ginkgo suite scaffolding.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.